Allow changing logo size in templates #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also set initial value in reducer
+ Bumped resize size from 125px to 500px. + Added new string: “Logo Size” for translation + Updated CSS
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After trying out a few logos with different shapes and sizes, I realized that the current style/CSS doesn't work well in some cases, such as when the logo is very wide and short, or the opposite, very narrow and tall.
This PR fixed this issue by allowing the user to customize the logo size.
Related Issue
Motivation and Context
Increase flexibility in customizing templates.
Types of changes
Checklist: