add devtron condition to devtools extension loader #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
mentioned this pull request
|
Maybe it's better to create a wiki page and link to it from the readme for the whole development section? |
Great idea! 👍 |
|
I'll try to write the first page about this tomorrow as i'm also writing the contributing guide. |
|
removed the readme changes ... |
ghost
changed the title
|
This is even better than a shortcut 👍 |
hql287
reviewed
Mar 3, 2018
| @@ -154,6 +154,8 @@ function createPreviewWindow() { | |||
| } | |||
|
|
|||
| function addDevToolsExtension() { | |||
| if (process.env.DEVTRON_DEV_TOOLS_PATH) | |||
There was a problem hiding this comment.
What would be the value of DEVTRON_DEV_TOOLS_PATH if I decided to use it?
There was a problem hiding this comment.
that would be the node_modules path, as it is part of the devDependencies:
DEVTRON_DEV_TOOLS_PATH=./node_modules/devtron
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
followup on #234.