Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed the multiple scrollbars bug for linux/windows #236

Merged
merged 5 commits into from Mar 2, 2018
Merged

fixed the multiple scrollbars bug for linux/windows #236

merged 5 commits into from Mar 2, 2018

Conversation

ghost
Copy link

@ghost ghost commented Mar 1, 2018

fix for #182

@ghost ghost mentioned this pull request Mar 1, 2018
5 tasks
@ghost
Copy link
Author

ghost commented Mar 1, 2018

now all scrollbars should be gone, all the scrollbar fans can just make the window smaller 😆

@hql287
Copy link
Owner

hql287 commented Mar 2, 2018

@jens-t: Can I have some screenshots, please? :)

@ghost
Copy link
Author

ghost commented Mar 2, 2018

here you go ...

bildschirmfoto-20180302132547-3247x1999
bildschirmfoto-20180302132618-1379x1940
bildschirmfoto-20180302132640-1583x1314
bildschirmfoto-20180302132713-1004x540

@hql287
Copy link
Owner

hql287 commented Mar 2, 2018

Looks good to me. Will check on macOS now.

@hql287
Copy link
Owner

hql287 commented Mar 2, 2018

@jens-t Can you confirm if this fixes #202 as well? Thanks!

@ghost
Copy link
Author

ghost commented Mar 2, 2018

Couldn't do a Screenshot of the TourWindow. How can i delete all my app data? it somehow persists, also after uninstall. Also all instances of the dev-server, installed and so on share the same app data. Can you please give me some infos about where and how the data is stored? Or are the indexeddb's of the app shared between the instances?

Then i can also take a look into #202.

@hql287
Copy link
Owner

hql287 commented Mar 2, 2018

Can you try Ctrl+T?

@ghost
Copy link
Author

ghost commented Mar 2, 2018

Yeah, Ctrl + T works ... do you also have some infos about the persistence of the data?

@ghost
Copy link
Author

ghost commented Mar 2, 2018

#202 is no overflow: scroll problem. so not really related, but i commit a fix for this into this branch ...

@ghost
Copy link
Author

ghost commented Mar 2, 2018

the height of the content is too big:
bildschirmfoto-20180302145132-1477x1273

One quick fix would be overflow: hidden or i could look why the height is too big, and fix that ...

@ghost
Copy link
Author

ghost commented Mar 2, 2018

Or are the indexeddb's of the app shared between the instances?

Yes, that's it. Deleted the indexed db's and the data is gone after restart.

@hql287
Copy link
Owner

hql287 commented Mar 2, 2018

How can i delete all my app data?

screen shot 2018-03-02 at 20 52 52

@hql287
Copy link
Owner

hql287 commented Mar 2, 2018

Can you please give me some infos about where and how the data is stored?

I don't think I'm qualified enough to explain this question. It's still quite a big mystery to me. 😂 Would love to know if you found something.

@ghost
Copy link
Author

ghost commented Mar 2, 2018

Should this PR be part of 1.1.3? I'm working on the #202 bug now ...

@hql287
Copy link
Owner

hql287 commented Mar 2, 2018

I'm already testing v1.1.3. This and your other PRs will be included in the next one – next Friday.

Take your time :)

@ghost
Copy link
Author

ghost commented Mar 2, 2018

Time taken, 4ed0472 is the fix for #202 :)
The slideImages caused an overflow in the slideWrapper ... disabled overflow for the slideWrapper.

@hql287
Copy link
Owner

hql287 commented Mar 2, 2018

@jens-t Can you do a screenshot? I think I can include this one with v1.1.3. Thanks!
Update: Confirmed everything's working in macOS

@hql287
Copy link
Owner

hql287 commented Mar 2, 2018

@jens-t: C'mon man, I need to see that screenshot 😂

@ghost
Copy link
Author

ghost commented Mar 2, 2018

Here you go ...

bildschirmfoto-20180302162324-1436x1237
bildschirmfoto-20180302162335-1430x1236
bildschirmfoto-20180302162345-1443x1245
bildschirmfoto-20180302162357-1444x1247
bildschirmfoto-20180302162409-1438x1246

@hql287 hql287 merged commit 484929f into hql287:dev Mar 2, 2018
@ghost
Copy link
Author

ghost commented Mar 2, 2018

And it's german 🎉 nice work with the multilanguage support!

@hql287
Copy link
Owner

hql287 commented Mar 2, 2018

It's kinda strange, but this thing somehow looks better with German written on it 😅

@ghost ghost deleted the multiple-scrollbars branch March 2, 2018 15:34
@hql287 hql287 mentioned this pull request Mar 2, 2018
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants