Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new languages #229

Merged
merged 7 commits into from
Mar 2, 2018
Merged

Add new languages #229

merged 7 commits into from
Mar 2, 2018

Conversation

hql287
Copy link
Owner

@hql287 hql287 commented Feb 28, 2018

Replace #207. Languages to be added & its respective translation progress:

In progress:

Finished:

Approved:

It would be nice to support at least 10 languages with this release 😜

@hql287
Copy link
Owner Author

hql287 commented Feb 28, 2018

Do you need help here? Or is the only blocker left here, resolving the conflicting files and merge into dev?
Would like to add a pull Request for local dates with moment js. And a refactor of the due date and date format form fields formatted based on the current locale. Thought it makes sense to wait for this merge.

@jens-t I merged #224 and forgot that it introduced some new keywords so now I need the translation for those new keywords in order to add that language to Manta. As a result, #207 become obsolete and this is the new PR to replace it.

What's your native language? Can you help me to add those missing translation on Crowdin? I can set you up as a proofreader for that language if you're up to it. Thanks!

@hql287 hql287 mentioned this pull request Feb 28, 2018
8 tasks
@ghost
Copy link

ghost commented Feb 28, 2018

Ah, ok. I can finish the german one. Maybe it is a good idea to merge before all languages are completed and use "en-US" as fallback for missing terms. It's just temporary and with new features there will be new terms and the translations will get uncomplete again. So a general fallback solution for missing terms could help. what do you think?

@ghost
Copy link

ghost commented Feb 28, 2018

Ok, german translation on crowdin is complete. What is the meaning of the "Net ..." labels?

@hql287
Copy link
Owner Author

hql287 commented Mar 1, 2018

Ah, ok. I can finish the german one. Maybe it is a good idea to merge before all languages are completed and use "en-US" as fallback for missing terms.

Yes, this is how it works at the moment. But I would like to make sure this release has all the necessary translation as it's the first one that supports multiple languages.

It's just temporary and with new features there will be new terms and the translations will get uncomplete again.

It's true, and I think having the translation for all the new keywords should be part of the PR. I'm writing about this in the contributing guideline in #226 where it goes into more details on this.

@hql287
Copy link
Owner Author

hql287 commented Mar 1, 2018

Ok, german translation on crowdin is complete.

Awesome! Thanks 👍

What is the meaning of the "Net ..." labels?

I think it's just a shorter way of saying "you have exactly 7, 10, 30 ... days to make the payment". I think you can just keep it as Net X as it always goes with the description.

@ghost
Copy link

ghost commented Mar 1, 2018

It's true, and I think having the translation for all the new keywords should be part of the PR. I'm writing about this in the contributing guideline in #226 where it goes into more details on this.

Ok, hope that goes well and no pull requests are blocked too long by missing new translation terms :) Waiting for the contribution guidelines then. Thanks for the info!

@hql287
Copy link
Owner Author

hql287 commented Mar 2, 2018

Five languages have been approved. Not too shabby, guys!!!👍

@hql287 hql287 merged commit 0d70616 into dev Mar 2, 2018
@hql287 hql287 deleted the add-new-languages branch March 2, 2018 13:36
@qpixHassaballah
Copy link

Hey I am working on an arabic translation on crowdin will it be in the next version?
I already see that someone already attempted multiple translations a year ago

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants