Add sensor to gardena #96691
Merged
Add sensor to gardena #96691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
elupus
force-pushed
the
gardena/sensor
branch
2 times, most recently
from
371de75
to
be15073
Compare
|
LGTM, but I'd like someone else to take a quick look to be completely confident |
bdraco
reviewed
Jul 16, 2023
| def _handle_coordinator_update(self) -> None: | ||
| value = self.coordinator.read_cached(self.entity_description.char) | ||
| if isinstance(value, datetime): | ||
| value = value.replace( |
There was a problem hiding this comment.
It would be better if the library provided times natively in utc so we don't have to convert here
There was a problem hiding this comment.
Device stores time in local time without knowledge about timezone.
There was a problem hiding this comment.
Suppose i could pass in timezone for the client on start. I will ponder a solution for future lib updates. I do agree
bdraco
approved these changes
Jul 16, 2023
20 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Add sensor entity to gardena bluetooth with battery information and timestamp of closure.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: