Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add already_in_progress to base strings for config flows #40961

Conversation

springstan
Copy link
Member

Breaking change

Proposed change

Adds already_in_progress to the base strings for config flows.
Uses this newly added base string in various integrations.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

This pull request needs to be manually signed off by @home-assistant/core before it can get merged.
(message by ReviewEnforcer)

Copy link
Contributor

@SNoof85 SNoof85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"already_in_progress": "[%key:common::config_flow::abort::no_devices_found%]" should be "already_in_progress": "[%key:common::config_flow::abort::already_in_progress%]"

@springstan
Copy link
Member Author

Thanks @SNoof85 for reviewing all of my PRs! I have fixed the wrong base string, probably a copy-paste error on my side.

@SNoof85
Copy link
Contributor

SNoof85 commented Oct 1, 2020

As you're faster than me to create i'll do reviews 👀

homeassistant/strings.json Outdated Show resolved Hide resolved
@@ -51,6 +51,7 @@
"already_configured_account": "Account is already configured",
"already_configured_service": "Service is already configured",
"already_configured_device": "Device is already configured",
"already_in_progress": "Config flow is already in progress",
Copy link
Member

@MartinHjelmare MartinHjelmare Oct 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We (a Lokalise admin) should rename this key in existing translations in Lokalise.

homeassistant/strings.json Outdated Show resolved Hide resolved
@MartinHjelmare
Copy link
Member

Please rebase again.

@MartinHjelmare MartinHjelmare merged commit 064a453 into home-assistant:dev Oct 3, 2020
@springstan springstan deleted the add-already-in-progress-to-base-strings-for-config-flows branch October 3, 2020 13:49
ronanmu pushed a commit to ronanmu/home-assistant that referenced this pull request Oct 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants