Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pyhaversion to 3.4.2 #40161

Merged
merged 1 commit into from
Sep 17, 2020
Merged

Update pyhaversion to 3.4.2 #40161

merged 1 commit into from
Sep 17, 2020

Conversation

ludeeus
Copy link
Member

@ludeeus ludeeus commented Sep 17, 2020

Breaking change

Proposed change

Update pyhaversion to 3.4.2
ludeeus/pyhaversion@3.4.0...3.4.2

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

sensor version:
  - platform: version
    source: pypi
    beta: true

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

Copy link
Member

@springstan springstan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 I am not sure if we should tag this for beta or not, what do you think @ludeeus?

@ludeeus ludeeus added this to the 0.115.0 milestone Sep 17, 2020
@ludeeus
Copy link
Member Author

ludeeus commented Sep 17, 2020

I doubt it will be a new beta, but added the milestone so it gets in the final (maybe?).
It's not really needed until the next time we reach 10+ beta versions 🙈

@ludeeus ludeeus merged commit a824213 into dev Sep 17, 2020
@ludeeus ludeeus deleted the version-dep-bump branch September 17, 2020 10:08
frenck pushed a commit that referenced this pull request Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Version Sensor Fails after Minor version greater than 9
5 participants