Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add onewire humidity sensors connected via DS2438 #39780

Merged

Conversation

epenet
Copy link
Contributor

@epenet epenet commented Sep 8, 2020

Proposed change

OWFS/OWServer automatically provide adjusted humidity calculations for various humidity sensors connected to DS2438:

  • Honeywell HIH3600
  • Honeywell HIH4000
  • Honeywell HIH5030
  • Humirel HTM1735

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant probot-home-assistant bot added integration: onewire small-pr PRs with less than 30 lines. labels Sep 8, 2020
@epenet epenet changed the title Add HIH3600/HIH4000/HIH5030/HTM1735 humidity sensors for DS2438 Add humidity sensors connected for DS2438 Sep 8, 2020
@MartinHjelmare MartinHjelmare changed the title Add humidity sensors connected for DS2438 Add onewire humidity sensors connected for DS2438 Sep 8, 2020
@epenet epenet marked this pull request as ready for review September 8, 2020 08:22
@epenet epenet changed the title Add onewire humidity sensors connected for DS2438 Add onewire humidity sensors connected via DS2438 Sep 8, 2020
@ctalkington ctalkington merged commit ea6ec42 into home-assistant:dev Sep 28, 2020
@epenet epenet deleted the onewire-ds2438-humidity-sensors branch September 28, 2020 06:56
@github-actions github-actions bot locked and limited conversation to collaborators Sep 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants