Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add switch platform to Comelit SmartHome #102233

Merged
merged 6 commits into from
Oct 18, 2023

Conversation

chemelli74
Copy link
Contributor

@chemelli74 chemelli74 commented Oct 18, 2023

Proposed change

Add switch platform to Comelit SmartHome in order to handle:

  • Irrigation
  • Outlet

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

homeassistant/components/comelit/switch.py Outdated Show resolved Hide resolved
homeassistant/components/comelit/switch.py Outdated Show resolved Hide resolved
homeassistant/components/comelit/switch.py Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft October 18, 2023 15:14
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@chemelli74 chemelli74 marked this pull request as ready for review October 18, 2023 15:49
Copy link
Member

@joostlek joostlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you open up a documentation PR, this PR is good!

@chemelli74
Copy link
Contributor Author

Thanks to the extensive testing of @eziocaliendo, who has a more complex and feature reach scenario than mine, I found a bug and did one more commit to fix it.

@chemelli74 chemelli74 merged commit b9c7613 into home-assistant:dev Oct 18, 2023
23 checks passed
@chemelli74 chemelli74 deleted the chemelli74-comelit-switches branch October 18, 2023 18:49
@github-actions github-actions bot locked and limited conversation to collaborators Oct 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants