Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update aiohttp to 3.8.6 #101590

Merged
merged 1 commit into from
Oct 7, 2023
Merged

Update aiohttp to 3.8.6 #101590

merged 1 commit into from
Oct 7, 2023

Conversation

cdce8p
Copy link
Member

@cdce8p cdce8p commented Oct 7, 2023 •
edited
Loading

Proposed change

https://github.com/aio-libs/aiohttp/releases/tag/v3.8.6
aio-libs/aiohttp@v3.8.5...v3.8.6

Wheel builder Github actions run: https://github.com/home-assistant/core/actions/runs/6442040020
Wheels are up at: https://wheels.home-assistant.io/musllinux/

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@cdce8p cdce8p requested a review from a team as a code owner October 7, 2023 15:34
@cdce8p cdce8p added this to the 2023.10.2 milestone Oct 7, 2023
@cdce8p cdce8p added the smash Indicator this PR is close to finish for merging or closing label Oct 7, 2023
jbouwh
jbouwh approved these changes Oct 7, 2023
View reviewed changes
Copy link
Contributor

@jbouwh jbouwh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
Thnx @cdce8p 👍

@cdce8p cdce8p merged commit bd93fbe into dev Oct 7, 2023
41 checks passed
@cdce8p cdce8p deleted the update-aiohttp-3.8.6 branch October 7, 2023 16:14
@github-actions github-actions bot locked and limited conversation to collaborators Oct 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jbouwh jbouwh jbouwh approved these changes

Assignees
No one assigned
Labels
cherry-picked cla-signed core dependency Hacktoberfest small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing
Projects
None yet
Milestone
2023.10.2
Development

Successfully merging this pull request may close these issues.
3 participants
@cdce8p @jbouwh @frenck