Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add config flow to AfterShip #100872

Merged
merged 5 commits into from
Sep 26, 2023
Merged

Add config flow to AfterShip #100872

merged 5 commits into from
Sep 26, 2023

Conversation

joostlek
Copy link
Member

@joostlek joostlek commented Sep 25, 2023 •
edited
Loading

Breaking change

The YAML configuration for color extractor is deprecated and will be removed in 2024.4. Please remove it from your configuration.

Proposed change

Add config flow to AfterShip

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant home-assistant bot added cla-signed config-flow This integration migrates to the UI by adding a config flow deprecation Indicates a breaking change to happen in the future has-tests integration: aftership new-feature Quality Scale: No score labels Sep 25, 2023
edenhaus
edenhaus requested changes Sep 26, 2023
View reviewed changes
homeassistant/components/aftership/sensor.py Show resolved Hide resolved
homeassistant/components/aftership/strings.json Outdated Show resolved Hide resolved
homeassistant/components/aftership/strings.json Outdated Show resolved Hide resolved
tests/components/aftership/conftest.py Show resolved Hide resolved
tests/components/aftership/test_config_flow.py Show resolved Hide resolved
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft September 26, 2023 07:35
@joostlek joostlek marked this pull request as ready for review September 26, 2023 15:19
edenhaus
edenhaus approved these changes Sep 26, 2023
View reviewed changes
Copy link
Contributor

@edenhaus edenhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @joostlek 👍

Fine to merge if CI passes

@joostlek joostlek mentioned this pull request Sep 26, 2023
Merged
8 tasks
@joostlek joostlek merged commit 074eb96 into home-assistant:dev Sep 26, 2023
34 checks passed
@joostlek joostlek deleted the aftership_cf branch September 26, 2023 16:05
dirrgang pushed a commit to dirrgang/core that referenced this pull request Sep 26, 2023
@joostlek @edenhaus @dirrgang
Add config flow to AfterShip (home-assistant#100872)
ad55ad6 
* Add config flow to Aftership

* Add config flow to Aftership

* Fix schema

* Update homeassistant/components/aftership/strings.json

Co-authored-by: Robert Resch <[email protected]>

* Fix feedback

---------

Co-authored-by: Robert Resch <[email protected]>
@github-actions github-actions bot locked and limited conversation to collaborators Sep 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@edenhaus edenhaus edenhaus approved these changes

Assignees
No one assigned
Labels
cla-signed config-flow This integration migrates to the UI by adding a config flow deprecation Indicates a breaking change to happen in the future has-tests integration: aftership new-feature Quality Scale: No score
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joostlek @edenhaus