Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update finish scripts for s6 v3 #2555

Merged
merged 3 commits into from
Jun 25, 2022
Merged

Update finish scripts for s6 v3 #2555

merged 3 commits into from
Jun 25, 2022

Conversation

mdegat01
Copy link
Contributor

@mdegat01 mdegat01 commented Jun 24, 2022

Update finish scripts for https://developers.home-assistant.io/blog/2022/05/12/s6-overlay-base-images

For most addons did not bump the version, just ensuring the next PR to go in doesn't have a surprise issue. Did bump the version for ZwaveJS and Deconz since they have all had recent updates so want to make new images without it.

deconz/config.yaml Show resolved Hide resolved
zwave_js/config.yaml Show resolved Hide resolved
ada/rootfs/etc/services.d/ada/finish Outdated Show resolved Hide resolved
almond/rootfs/etc/services.d/almond/finish Outdated Show resolved Hide resolved
almond/rootfs/etc/services.d/nginx/finish Outdated Show resolved Hide resolved
configurator/rootfs/etc/services.d/configurator/finish Outdated Show resolved Hide resolved
deconz/rootfs/etc/services.d/deconz/finish Outdated Show resolved Hide resolved
zwave/rootfs/etc/services.d/mosquitto/finish Outdated Show resolved Hide resolved
zwave/rootfs/etc/services.d/ozwadmin/finish Outdated Show resolved Hide resolved
zwave/rootfs/etc/services.d/websockify/finish Outdated Show resolved Hide resolved
zwave/rootfs/etc/services.d/zwave/finish Outdated Show resolved Hide resolved
zwave_js/rootfs/etc/services.d/zwave_js/finish Outdated Show resolved Hide resolved
@mdegat01 mdegat01 requested a review from frenck June 24, 2022 22:41
@mdegat01
Copy link
Contributor Author

mdegat01 commented Jun 24, 2022

@pvizeli After this one is merged I'll do another PR pass to add codenotary to all the ones missing it. But I did add it to the 2 with the version being bumped now since that makes sense.

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @mdegat01 👍

I think this looks good and can be merged (if we follow up with the codenotary change as suggested by Pascal in follow-up PR).

@mdegat01 mdegat01 merged commit 5d21f08 into master Jun 25, 2022
@delete-merged-branch delete-merged-branch bot deleted the fix-finish-scripts branch June 25, 2022 19:06
scolby33 pushed a commit to scolby33/addons that referenced this pull request Apr 4, 2023
* Bump version for addons with recent updates

* Use exec and add codenotary

* Codenotary not a boolean
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants