Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve compatibility with dask-expr #1335

Merged
merged 6 commits into from
May 23, 2024
Merged

Improve compatibility with dask-expr #1335

merged 6 commits into from
May 23, 2024

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented May 21, 2024

Fixes #1331

  • Needs to add a test
  • Add comment about the line

@hoxbro hoxbro requested a review from jbednar May 21, 2024 17:13
datashader/tests/test_dask.py Outdated Show resolved Hide resolved
Copy link

codecov bot commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.61%. Comparing base (7c1111c) to head (d9ba50a).
Report is 5 commits behind head on main.

Current head d9ba50a differs from pull request most recent head 54f5453

Please upload reports for the commit 54f5453 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1335      +/-   ##
==========================================
+ Coverage   85.58%   85.61%   +0.03%     
==========================================
  Files          51       50       -1     
  Lines       11290    11263      -27     
==========================================
- Hits         9662     9643      -19     
+ Misses       1628     1620       -8     

@hoxbro hoxbro changed the title Fix datashader + dask_expr problem Improve compatibility with dask_expr May 21, 2024
@hoxbro hoxbro changed the title Improve compatibility with dask_expr Improve compatibility with dask-expr May 22, 2024
@hoxbro hoxbro added this to the v0.16.2 milestone May 22, 2024
@hoxbro hoxbro merged commit 1bf733e into main May 23, 2024
17 checks passed
@hoxbro hoxbro deleted the fix_datashade_dask_expr branch May 23, 2024 13:16
hoxbro added a commit that referenced this pull request May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants