Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove artifact from Polygon rendering #1329

Merged
merged 7 commits into from
May 10, 2024
Merged

Remove artifact from Polygon rendering #1329

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ddcc005
Remove artifact from Polygon rendering
hoxbro May 8, 2024
0eb9b4e
Add some isclose
hoxbro May 8, 2024
35946e9
Remove + 1
hoxbro May 8, 2024
f285f64
Revert non-essential changes
hoxbro May 9, 2024
b7ab59f
Update tests to match new implementation
hoxbro May 9, 2024
0f477ad
Exclude Python 3.9 + Windows as it won't solve
hoxbro May 9, 2024
2d16fe7
Apply suggestions from code review
hoxbro May 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove + 1
  • Loading branch information
@hoxbro
hoxbro committed May 8, 2024
commit 35946e941c689896ed02e61a70137e6b6029a68b
4 changes: 2 additions & 2 deletions datashader/glyphs/polygon.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,11 +130,11 @@ def draw_polygon(
append(i, startxi, startyi, *aggs_and_cols)
return
elif (stopxi - startxi) == 1:
for yi in range(min(startyi, stopyi) + 1, max(startyi, stopyi)):
for yi in range(min(startyi, stopyi), max(startyi, stopyi)):
append(i, startxi, yi, *aggs_and_cols)
return
elif (stopyi - startyi) == 1:
for xi in range(min(startxi, stopxi) + 1, max(startxi, stopxi)):
for xi in range(min(startxi, stopxi), max(startxi, stopxi)):
append(i, xi, startyi, *aggs_and_cols)
return

Expand Down
Loading