Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support antialiased line self_intersect in categorical aggs #1083

Merged
merged 1 commit into from
May 5, 2022
Merged

Support antialiased line self_intersect in categorical aggs #1083

merged 1 commit into from
May 5, 2022

Conversation

ianthomas23
Copy link
Member

PR #1081 (antialiased lines for categorical aggs) didn't include support for 1-stage agg (self_intersect=True) as introduced by PR #1072. This PR fixes it.

Demo of fix:
aa_cat_self_intersect
Note the self-intersections near the center of the second plot. Before this fix the second plot looked the same as the first.

@codecov
Copy link

codecov bot commented May 5, 2022

Codecov Report

Merging #1083 (7407b39) into master (1cacb25) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1083   +/-   ##
=======================================
  Coverage   83.35%   83.35%           
=======================================
  Files          34       34           
  Lines        7490     7491    +1     
=======================================
+ Hits         6243     6244    +1     
  Misses       1247     1247           
Impacted Files Coverage Δ
datashader/core.py 88.11% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1cacb25...7407b39. Read the comment docs.

@jbednar jbednar merged commit 59d1d2d into holoviz:master May 5, 2022
@philippjfr philippjfr added this to the v0.14.1 milestone Jun 10, 2022
@ianthomas23 ianthomas23 modified the milestones: v0.14.2, v0.14.1 Jul 18, 2022
@ianthomas23 ianthomas23 deleted the aa_cat_self_intersect branch July 19, 2023 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants