Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix!: Compressing private key should ensure string format #1736

Open
wants to merge 1 commit into
base: 07-31-refactor_remove_wrapper_type_for_message_signatures
Choose a base branch
from
Open

fix!: Compressing private key should ensure string format #1736

wants to merge 1 commit into from

Conversation

janniks
Copy link
Collaborator

@janniks janniks commented Jul 31, 2024 •
edited by github-actions bot
Loading

This PR was published to npm with the version 6.14.1-pr.62+e179e1d5
e.g. npm install @stacks/[email protected]+e179e1d5 --save-exact

  • Change private key defaults to string -- This is what most users will expect when handling private-keys (and it matches what we're doing with public keys)

@vercel Vercel
Copy link

vercel bot commented Jul 31, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
stacksjs-docs 🛑 Canceled (Inspect) Sep 17, 2024 3:30pm

@codecov Codecov
Copy link

codecov bot commented Jul 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@janniks janniks requested a review from rafaelcr August 1, 2024 12:55
@janniks janniks force-pushed the 07-31-refactor_remove_wrapper_type_for_message_signatures branch from c98560d to 38f19a4 Compare September 17, 2024 14:15
@janniks janniks force-pushed the 08-01-fix_compressing_private_key_should_ensure_string_format branch from dbe8e9d to 1350468 Compare September 17, 2024 14:15
@janniks janniks force-pushed the 07-31-refactor_remove_wrapper_type_for_message_signatures branch from 38f19a4 to e4ccb7b Compare September 17, 2024 14:35
@janniks janniks force-pushed the 08-01-fix_compressing_private_key_should_ensure_string_format branch 2 times, most recently from c15fde6 to 99da44c Compare September 17, 2024 14:46
@janniks janniks force-pushed the 07-31-refactor_remove_wrapper_type_for_message_signatures branch from e4ccb7b to 021de01 Compare September 17, 2024 14:46
@janniks janniks force-pushed the 08-01-fix_compressing_private_key_should_ensure_string_format branch from 99da44c to dc9ccf9 Compare September 17, 2024 14:50
@janniks janniks force-pushed the 07-31-refactor_remove_wrapper_type_for_message_signatures branch from 021de01 to 4128a88 Compare September 17, 2024 14:50
@janniks janniks force-pushed the 08-01-fix_compressing_private_key_should_ensure_string_format branch from dc9ccf9 to e5a99c1 Compare September 17, 2024 14:54
@janniks janniks force-pushed the 07-31-refactor_remove_wrapper_type_for_message_signatures branch 2 times, most recently from 9dc7897 to deff67c Compare September 17, 2024 14:57
@janniks janniks force-pushed the 08-01-fix_compressing_private_key_should_ensure_string_format branch from e5a99c1 to 6a34508 Compare September 17, 2024 14:57
@janniks janniks force-pushed the 07-31-refactor_remove_wrapper_type_for_message_signatures branch from deff67c to dd3d351 Compare September 17, 2024 14:59
@janniks janniks force-pushed the 08-01-fix_compressing_private_key_should_ensure_string_format branch 2 times, most recently from 0f2dc80 to f9b380e Compare September 17, 2024 15:00
@janniks janniks force-pushed the 07-31-refactor_remove_wrapper_type_for_message_signatures branch 2 times, most recently from cd93ad2 to cde2425 Compare September 17, 2024 15:00
@janniks janniks force-pushed the 08-01-fix_compressing_private_key_should_ensure_string_format branch from f9b380e to 234edcf Compare September 17, 2024 15:00
@janniks janniks force-pushed the 07-31-refactor_remove_wrapper_type_for_message_signatures branch from cde2425 to f1e866f Compare September 17, 2024 15:02
@janniks janniks force-pushed the 08-01-fix_compressing_private_key_should_ensure_string_format branch from 234edcf to 03f59ab Compare September 17, 2024 15:02
@janniks janniks force-pushed the 07-31-refactor_remove_wrapper_type_for_message_signatures branch from f1e866f to 8c4fc6d Compare September 17, 2024 15:04
@janniks janniks force-pushed the 08-01-fix_compressing_private_key_should_ensure_string_format branch 2 times, most recently from 784a87b to 96c8642 Compare September 17, 2024 15:05
@janniks janniks force-pushed the 07-31-refactor_remove_wrapper_type_for_message_signatures branch from 8c4fc6d to 59652dc Compare September 17, 2024 15:05
@janniks janniks force-pushed the 08-01-fix_compressing_private_key_should_ensure_string_format branch from 96c8642 to 8f3175e Compare September 17, 2024 15:06
@janniks janniks force-pushed the 07-31-refactor_remove_wrapper_type_for_message_signatures branch 2 times, most recently from e585817 to d36b414 Compare September 17, 2024 15:06
@janniks janniks force-pushed the 08-01-fix_compressing_private_key_should_ensure_string_format branch from 8f3175e to c22fc13 Compare September 17, 2024 15:06
@janniks janniks force-pushed the 07-31-refactor_remove_wrapper_type_for_message_signatures branch from d36b414 to fffc7af Compare September 17, 2024 15:07
@janniks janniks force-pushed the 08-01-fix_compressing_private_key_should_ensure_string_format branch from c22fc13 to 77f2e7e Compare September 17, 2024 15:07
@janniks janniks force-pushed the 07-31-refactor_remove_wrapper_type_for_message_signatures branch from fffc7af to 809f824 Compare September 17, 2024 15:08
@janniks janniks force-pushed the 08-01-fix_compressing_private_key_should_ensure_string_format branch 2 times, most recently from b2b07f1 to c278fe0 Compare September 17, 2024 15:11
@janniks janniks force-pushed the 07-31-refactor_remove_wrapper_type_for_message_signatures branch 2 times, most recently from 63a2cc8 to f18aaf1 Compare September 17, 2024 15:12
@janniks janniks force-pushed the 08-01-fix_compressing_private_key_should_ensure_string_format branch from c278fe0 to 0d2037d Compare September 17, 2024 15:12
@janniks janniks force-pushed the 08-01-fix_compressing_private_key_should_ensure_string_format branch from 0d2037d to e179e1d Compare September 17, 2024 15:13
@janniks janniks force-pushed the 07-31-refactor_remove_wrapper_type_for_message_signatures branch from f18aaf1 to 30c9b6c Compare September 17, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafaelcr rafaelcr rafaelcr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
DevTools
Status: 👀 In Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@janniks @rafaelcr