Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: Remove wrapper type for message signatures #1735

Open
wants to merge 1 commit into
base: 07-31-refactor_remove_serialize_prefix_from_enum_keys
Choose a base branch
from
Open

refactor!: Remove wrapper type for message signatures #1735

wants to merge 1 commit into from

Conversation

janniks
Copy link
Collaborator

@janniks janniks commented Jul 31, 2024 •
edited by github-actions bot
Loading

This PR was published to npm with the version 6.14.1-pr.61+30c9b6c6
e.g. npm install @stacks/[email protected]+30c9b6c6 --save-exact

  • Prefer direct string instead of message signature wrapper type
  • Add PublicKey super type where TS complained

@vercel Vercel
Copy link

vercel bot commented Jul 31, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
stacksjs-docs 🛑 Canceled (Inspect) Sep 17, 2024 3:35pm

@janniks janniks requested a review from beguene July 31, 2024 21:47
@codecov Codecov
Copy link

codecov bot commented Jul 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

beguene
beguene approved these changes Aug 1, 2024
View reviewed changes
Copy link
Contributor

@beguene beguene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is much cleaner !

@janniks janniks force-pushed the 07-31-refactor_remove_serialize_prefix_from_enum_keys branch from 8d60f83 to a36cbb6 Compare September 17, 2024 14:15
@janniks janniks force-pushed the 07-31-refactor_remove_wrapper_type_for_message_signatures branch 2 times, most recently from 38f19a4 to e4ccb7b Compare September 17, 2024 14:35
@janniks janniks force-pushed the 07-31-refactor_remove_serialize_prefix_from_enum_keys branch 2 times, most recently from e6acc3f to a284cce Compare September 17, 2024 14:46
@janniks janniks force-pushed the 07-31-refactor_remove_wrapper_type_for_message_signatures branch 2 times, most recently from 021de01 to 4128a88 Compare September 17, 2024 14:50
@janniks janniks force-pushed the 07-31-refactor_remove_serialize_prefix_from_enum_keys branch 2 times, most recently from 088c326 to b0c2d1c Compare September 17, 2024 14:54
@janniks janniks force-pushed the 07-31-refactor_remove_wrapper_type_for_message_signatures branch from 4128a88 to 9dc7897 Compare September 17, 2024 14:54
@janniks janniks force-pushed the 07-31-refactor_remove_wrapper_type_for_message_signatures branch from 9dc7897 to deff67c Compare September 17, 2024 14:57
@janniks janniks force-pushed the 07-31-refactor_remove_serialize_prefix_from_enum_keys branch from b0c2d1c to 312b7b7 Compare September 17, 2024 14:57
@janniks janniks force-pushed the 07-31-refactor_remove_wrapper_type_for_message_signatures branch from deff67c to dd3d351 Compare September 17, 2024 14:59
@janniks janniks force-pushed the 07-31-refactor_remove_serialize_prefix_from_enum_keys branch from 312b7b7 to b475417 Compare September 17, 2024 14:59
@janniks janniks force-pushed the 07-31-refactor_remove_wrapper_type_for_message_signatures branch from dd3d351 to cd93ad2 Compare September 17, 2024 15:00
@janniks janniks force-pushed the 07-31-refactor_remove_serialize_prefix_from_enum_keys branch 2 times, most recently from 5c7ce57 to f1911ac Compare September 17, 2024 15:00
@janniks janniks force-pushed the 07-31-refactor_remove_wrapper_type_for_message_signatures branch 2 times, most recently from cde2425 to f1e866f Compare September 17, 2024 15:02
@janniks janniks force-pushed the 07-31-refactor_remove_serialize_prefix_from_enum_keys branch from f1911ac to d8a0152 Compare September 17, 2024 15:02
@janniks janniks force-pushed the 07-31-refactor_remove_wrapper_type_for_message_signatures branch from f1e866f to 8c4fc6d Compare September 17, 2024 15:04
@janniks janniks force-pushed the 07-31-refactor_remove_serialize_prefix_from_enum_keys branch 2 times, most recently from 775aa20 to ce91fcf Compare September 17, 2024 15:05
@janniks janniks force-pushed the 07-31-refactor_remove_wrapper_type_for_message_signatures branch 2 times, most recently from 59652dc to e585817 Compare September 17, 2024 15:06
@janniks janniks force-pushed the 07-31-refactor_remove_serialize_prefix_from_enum_keys branch from ce91fcf to 823f4f6 Compare September 17, 2024 15:06
@janniks janniks force-pushed the 07-31-refactor_remove_wrapper_type_for_message_signatures branch from e585817 to d36b414 Compare September 17, 2024 15:06
@janniks janniks force-pushed the 07-31-refactor_remove_serialize_prefix_from_enum_keys branch from 823f4f6 to 3d9dd3d Compare September 17, 2024 15:06
@janniks janniks force-pushed the 07-31-refactor_remove_wrapper_type_for_message_signatures branch 2 times, most recently from fffc7af to 809f824 Compare September 17, 2024 15:08
@janniks janniks force-pushed the 07-31-refactor_remove_serialize_prefix_from_enum_keys branch 2 times, most recently from a31af58 to a494462 Compare September 17, 2024 15:11
@janniks janniks force-pushed the 07-31-refactor_remove_wrapper_type_for_message_signatures branch 2 times, most recently from 63a2cc8 to f18aaf1 Compare September 17, 2024 15:12
@janniks janniks force-pushed the 07-31-refactor_remove_serialize_prefix_from_enum_keys branch from a494462 to a0e81d6 Compare September 17, 2024 15:12
@janniks janniks force-pushed the 07-31-refactor_remove_serialize_prefix_from_enum_keys branch from a0e81d6 to e8047ea Compare September 17, 2024 15:13
@janniks janniks force-pushed the 07-31-refactor_remove_wrapper_type_for_message_signatures branch from f18aaf1 to 30c9b6c Compare September 17, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beguene beguene beguene approved these changes

Assignees

@janniks janniks

Labels
None yet
Projects
DevTools
Status: 👀 In Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@janniks @beguene