-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stan updates #3413
Stan updates #3413
Conversation
src/languages/stan.js
Outdated
end: /$/, | ||
relevance: 0, // relevance comes from keywords | ||
keywords: "include", | ||
keywords: '#include', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty sure this won't work without using $pattern
as # isn't a normal keyword character.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You only seeing the meta
highlighting... the keywords
isn't working there at all because the "#" is not matched by IDENT_RE, which is what Stan uses for keyword pattern matching.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed keywords and just use the meta highlighting as I think it looks good. Let me know if this goes against the package design philosophy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's probably ok... I'll make a final pass and clean it up later if necessary. The relevancy may have to be tuned now, etc... but it likely looked weird before for some themes so I'm ok changing it.
68df2ea
to
54f14dc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @joshgoebel, commit "clean up grammar" broke the stan syntax highlighting for me. Nothing gets highlighted, reverting this and stan highlighting works.
Edit: It's all from line 10. I'll put that back in but feel free to update to whatever you intended
Oh line 10 is broken that's weird. |
Co-authored-by: Josh Goebel <[email protected]>
🎉 |
Thanks all for the great work! |
Resolves #3410
Changes
Updated Stan highlighter for Stan version 2.28
Improvements over previous
Checklist
CHANGES.md