Add Heroku-20 to the Travis test matrix #404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To confirm that the buildpack works on the preview of the new stack. The install step has also been updated to only pull the image being tested, rather than all of the images for each job in the matrix, saving 2 minutes per job. I had to recompile Yara in the `godep-cgo-vendored` fixture, since it was linked against `libssl1.0.0` which is not available for Ubuntu 20.04. Since there isn't a single libssl version that is supported across all of our stacks (`libssl1.1` is only available for Ubuntu 18.04+), I used `configure --without-crypto` to remove the OpenSSL dependency entirely. The removed files were all redundant for the purposes of that test. Refs W-7472042.
edmorley
force-pushed
the
edmorley-test-heroku-20
branch
from
a9c003d
to
4352e49
Compare
danielleadams
approved these changes
Apr 21, 2020
danp
reviewed
Apr 21, 2020
| - docker pull heroku/cedar:14 | ||
| - docker pull heroku/heroku:16-build | ||
| - docker pull heroku/heroku:18-build | ||
| - docker pull $IMAGE |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To confirm that the buildpack works on the preview of the new stack.
The install step has also been updated to only pull the image being tested, rather than all of the images for each job in the matrix, saving 2 minutes per job.
I had to recompile Yara 3.4.0 in the
godep-cgo-vendoredfixture, since it was linked againstlibssl1.0.0which is not available for Ubuntu 20.04.Since there isn't a single libssl version that is supported across all of our stacks (
libssl1.1is only available for Ubuntu 18.04+), I usedconfigure --without-cryptoto remove Yara's dependency on OpenSSL entirely.The removed files were all redundant for the purposes of that test.
Refs W-7472042.