fix(pg-v5): Fix databasename for URLs with query element and be more consistent #1882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbarber
changed the title
…consistent For operations such as pg:psql, we have been assuming that the URL parsed path method is enough to find the database name. This is incorrect when we pass parameters such as sslmode. In general, this problem has been solved with parsePostgresConnectionString but not everything uses it. This fix removes any custom parsing we are doing of URLs and moves to using this function everywhere to avoid inconsistency. * util.databaseNameFromUrl * util.getConnectionDetails * the pg:copy resolver Without this, pg:psql was failing on verify-full URL's but with this patch, it works fine.
kbarber
changed the title
kbarber
force-pushed
the
support_url_parameters_for_pgpsql
branch
from
2734866
to
45862c1
Compare
ncode
approved these changes
Nov 15, 2021
tevanoff
reviewed
Nov 15, 2021
Thanks for the review :-). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For operations such as pg:psql, we have been assuming that the URL parsed
pathmethod is enough to find the database name. This is incorrect when we pass parameters such assslmode. In general, this problem has been solved withparsePostgresConnectionStringbut not everything uses it.This fix removes any custom parsing we are doing of URLs and moves to using this function everywhere to avoid inconsistency.
Without this,
pg:psqlwas failing on verify-full URL's but with this patch, it works fine.