Skip to content

Commit

Permalink
Merge pull request #254 from IanCa/admin_update_scripts
Browse files Browse the repository at this point in the history
Update check_schemas to v44 changed_files, update error message in verify_branch.sh
  • Loading branch information
VisLab committed Jul 30, 2024
2 parents b00ea48 + a4f9ee0 commit 924e171
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/add_hed_ids.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ on:


jobs:
manage-branch:
create-hed-ids-pr:
runs-on: ubuntu-latest
steps:
- name: Checkout code
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/update_and_convert_schemas.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ on:


jobs:
check_changes:
update-schemas-with-changes:
runs-on: ubuntu-latest
steps:
- name: Checkout code
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ on:
branches: ["*"]

jobs:
process-changed-files:
validate-schemas:
runs-on: ubuntu-latest

steps:
Expand All @@ -22,7 +22,7 @@ jobs:

- name: Get changed files
id: changed-files
uses: tj-actions/changed-files@v41
uses: tj-actions/changed-files@v44
# To compare changes between the current commit and the last pushed remote commit set `since_last_remote_commit: true`. e.g
# with:
# since_last_remote_commit: true
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/verify_source_branch.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ on:


jobs:
print_branch_name:
verify-source-branch:
runs-on: ubuntu-latest
env:
BRANCH_NAME: ${{ github.head_ref }} # Set the variables used by the verify_branch script
Expand Down
2 changes: 1 addition & 1 deletion scripts/verify_branch.sh
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ for file in "$@"; do # "$@" will contain the list of modified files passed by p
else
# Allow other files to be modified anywhere under the base pattern directory
if [[ "$file" != "$base_pattern"* ]]; then
error_message+="Error: '$file' should not be modified on this branch. Only files under '$base_pattern' directory\n"
error_message+="Error: '$file' should not be modified on this branch. Only files under '$base_pattern' directory should be modified.\n"
fi

fi
Expand Down

0 comments on commit 924e171

Please sign in to comment.