Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tls_ca_file option for verifying client #3034

Merged
merged 5 commits into from
Aug 3, 2017
Merged

tls_ca_file option for verifying client #3034

merged 5 commits into from
Aug 3, 2017

Conversation

gobins
Copy link
Contributor

@gobins gobins commented Jul 19, 2017

Fixes #2708

@jefferai jefferai added this to the 0.8.0 milestone Aug 2, 2017
jefferai
jefferai requested changes Aug 2, 2017
View reviewed changes
Copy link
Member

@jefferai jefferai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good, however I have one concern: I think it will be easy for users (not paying attention) to assume that this is the CA file for the server process, not the clients. I'd prefer if it was called tls_client_ca_file instead.

@jefferai
Copy link
Member

jefferai commented Aug 3, 2017

Thanks!

@jefferai jefferai merged commit f166016 into hashicorp:master Aug 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jefferai jefferai jefferai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.8.0
Development

Successfully merging this pull request may close these issues.
2 participants
@gobins @jefferai