Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Includes and String requirement on Paths #51

Closed
zachleat opened this issue Dec 15, 2017 · 3 comments
Closed

Includes and String requirement on Paths #51

zachleat opened this issue Dec 15, 2017 · 3 comments

Comments

@zachleat
Copy link
Contributor

(Love this library—thank you!)

This is going to be a very specific nitpick so just keep that in mind. I wanted to use this lib to parse some existing Jekyll templates and while I don’t expect a completely fluid parse, one thing that did trip me up: Jekyll includes.

Specifically, Jekyll uses {% include footer.html %} (without quotes) and this library expects {% include 'footer.html' %} (quotes). I suppose I just have a question: is this a limitation of the library (something that could be worked around) or a limitation of any non-Ruby implementation?

Thanks!
Zach

@harttle
Copy link
Owner

harttle commented Dec 17, 2017

This is a intended in liquidjs, to support dynamic including.

All built-in tags can be override by register a new Tag, you can simply write your include. But I'm thinking about support this by some kind of options, like {include: 'static'}. What do you think?

@harttle
Copy link
Owner

harttle commented Dec 21, 2017

Published @ 2.2.0. Setting dynamicPartials to false enables this feature.

@zachleat
Copy link
Contributor Author

Oh, wow! Amazing—thank you!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants