Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor of sumproduct #826

Merged
merged 6 commits into from
Oct 6, 2021
Merged

refactor of sumproduct #826

merged 6 commits into from
Oct 6, 2021

Conversation

izulin
Copy link
Collaborator

@izulin izulin commented Sep 28, 2021

Context

SUMPRODUCT supports variable #args

How has this been tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature or improvement (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Additional language file or change to the existing one (translations)

Related issue(s):

  1. SUMPRODUCT with +3 arrays results with N/A #810

Checklist:

  • My code follows the code style of this project,
  • My change requires a change to the documentation,
  • I described the modification in the CHANGELOG.md file.

@codecov
Copy link

codecov bot commented Sep 28, 2021

Codecov Report

Merging #826 (92e2d6d) into develop (6ee4e70) will decrease coverage by 0.00%.
The diff coverage is 79.16%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #826      +/-   ##
===========================================
- Coverage    92.43%   92.43%   -0.01%     
===========================================
  Files          167      167              
  Lines        40302    40305       +3     
  Branches      5576     5579       +3     
===========================================
+ Hits         37253    37254       +1     
- Misses        3043     3045       +2     
  Partials         6        6              
Impacted Files Coverage Δ
src/interpreter/plugin/SumprodPlugin.ts 89.47% <79.16%> (-3.12%) ⬇️

CHANGELOG.md Outdated
@@ -6,6 +6,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Added
- Added support for more args to SUMPRODUCT function. (#810)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It shouldn't be in "Fixed" category? SUMPRODUCT should support more args from the start. And according to docs it was announced that it does.

src/interpreter/plugin/SumprodPlugin.ts Outdated Show resolved Hide resolved
test/interpreter/function-sumproduct.spec.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@wojciechczerniak wojciechczerniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🏆

@izulin izulin merged commit 005a616 into develop Oct 6, 2021
@izulin izulin deleted the pu/sumproduct branch October 6, 2021 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants