fix : #768 issue #770
Closed
fix : #768 issue #770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
also, an official repository of the "hammerjs" did not merge an issue #688 in hammer.js file. |
sculove
added a commit
to naver/hammer.js
that referenced
this pull request
Jun 16, 2015
|
@sculove this contains unrelated changes and some things that have already been merged from other pr's do you think you could update this? |
|
Ok. I will resend pr. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
modified a Hammerjs.Manager.off method.
When you didn't attach an event and you use a Hammerjs.Manager.off method , you will see script error.
I think that hammerjs have to handle exception.
I modified Hammerjs.Manager.off method.
also I added test case in test_events.js