melt.data.frame no longer barfs with POSIXlt

[kevinushey]

No description provided.

[kevinushey]

@hadley no idea what this error is:

+Rscript -e 'library(devtools); library(methods); options(repos=c(CRAN="http://cran.rstudio.com")); install_github(commandArgs(TRUE), build_vignettes = FALSE)' plyr
Error in username %||% getOption("github.user") %||% stop("Unknown username.") : 
  Unknown username.
Calls: install_github -> lapply -> FUN -> %||%

[hadley]

I'd be tempted to just make this an error

[hadley]

I feel comfortable throwing errors whenever you see a POSIXlt because:

class(data.frame(as.POSIXlt(Sys.time()))[[1]])
# POSIXct

[kevinushey]

Okay, I'll copy what you did in tidyr here.

[jimhester]

@kevinushey https://github.com/hadley/reshape/blob/master/.travis.yml#L8 needs to be ./travis-tool.sh install_github hadley/plyr rather than just plyr

This must have been written back in the old days when Hadley was the default user for devtools. 😄

added PR #70 to fix this

[kevinushey]

@jimhester thanks for looking into that! Ah, the good old days ;)

@hadley, I've updated the PR (essentially conforming with what you've done in tidyr)

[hadley]

Could you please merge/rebase to get the updated .travis.yml?

[kevinushey]

Done; hopefully all should be well now.

[hadley]

Thanks!