Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Social account recovery option & modal instead of toast #806

Merged
merged 5 commits into from
Jun 6, 2023

Conversation

cs-balazs
Copy link
Contributor

Social account recovery option & modal instead of toast

Putting the modal inside Web3ConnectionManager didn't seem that good, but creating a separate context just for this modal seemed worse, I'd be happy to hear your suggestions on where to put the modal itself!

WIP because the modal content needs to be polished

@cs-balazs cs-balazs added the improvement Ui, code, scalablity, security improvements label May 25, 2023
@cs-balazs cs-balazs self-assigned this May 25, 2023
@vercel
Copy link

vercel bot commented May 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
guild-xyz ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 6, 2023 1:07pm

@cs-balazs cs-balazs changed the title [WIP] Social account recovery option & modal instead of toast Social account recovery option & modal instead of toast Jun 6, 2023
@cs-balazs cs-balazs marked this pull request as ready for review June 6, 2023 12:56
@cs-balazs cs-balazs merged commit 171f1fc into main Jun 6, 2023
@BrickheadJohnny BrickheadJohnny deleted the connect-platform-error-hangling branch June 10, 2023 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Ui, code, scalablity, security improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants