Support new "Upload attachment" endpoint #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mesozoic
force-pushed
the
upload_attachment
branch
from
595a5d6
to
96b3d59
Compare
Along the way I moved orm.changes -> orm.lists and renamed ChangeNotifyingList -> ChangeTrackingList
mesozoic
force-pushed
the
upload_attachment
branch
from
96b3d59
to
869408c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch adds
Table.upload_attachment()andModel.attachments_field.upload()to support the recently introduced Upload attachment endpoint. Along the way it required a bit of a rethink of how we handle lists in the ORM, especially after #381 introduced a custom list subclass (which makes the type system for the ORM a bit more complex).