Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to use safeLoad for loading YML files via file.readYAML. #1719

Merged
merged 1 commit into from
Aug 18, 2020

Conversation

vladikoff
Copy link
Member

For previous behaviour please use the following:

readYAML('test/fixtures/utf8.yaml', null, {unsafeLoad: true});

@shama got a sec for an r? 👀

For previous behaviour please use the following:

```
readYAML('test/fixtures/utf8.yaml', null, {unsafeLoad: true});
```
@vladikoff vladikoff requested a review from shama August 17, 2020 15:33
@shama
Copy link
Member

shama commented Aug 18, 2020

Seems 👍 to me. I guess if someone is relying on it loading unsafely by default their build will break with this change. IMO is a good thing because if they're relying on an unsafe API they should be explicit about it. My 2 cents.

@vladikoff vladikoff merged commit 7e669ac into master Aug 18, 2020
@vladikoff vladikoff deleted the yaml-refactor branch August 18, 2020 19:02
@vladikoff
Copy link
Member Author

Thank you @shama !!! 🎁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants