Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

balancer/leastrequest: Add verbosity check around build log #7467

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

zasweq
Copy link
Contributor

@zasweq zasweq commented Aug 1, 2024

Fixes #7463.

RELEASE NOTES: N/A

@zasweq zasweq requested a review from dfawley August 1, 2024 02:17
@zasweq zasweq added the Type: Meta Github repo, process, etc label Aug 1, 2024
@zasweq zasweq added this to the 1.66 Release milestone Aug 1, 2024
Copy link

codecov bot commented Aug 1, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 81.35%. Comparing base (6fa393c) to head (340e58f).

Files Patch % Lines
balancer/leastrequest/leastrequest.go 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7467      +/-   ##
==========================================
- Coverage   81.38%   81.35%   -0.04%     
==========================================
  Files         354      354              
  Lines       27080    27081       +1     
==========================================
- Hits        22040    22032       -8     
- Misses       3831     3835       +4     
- Partials     1209     1214       +5     
Files Coverage Δ
balancer/leastrequest/leastrequest.go 88.88% <0.00%> (-3.05%) ⬇️

... and 15 files with indirect coverage changes

@dfawley dfawley assigned zasweq and unassigned dfawley Aug 1, 2024
@zasweq zasweq merged commit 4a26a49 into grpc:master Aug 1, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Meta Github repo, process, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Logger Performance When Disabled
2 participants