Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

advancedtls: add CipherSuites to Options #7269

Merged
merged 1 commit into from
May 29, 2024

Conversation

matthewstevenson88
Copy link
Contributor

@matthewstevenson88 matthewstevenson88 commented May 24, 2024

Plumb the ciphersuites through the advanced TLS stack's options struct down to the tls.Config. This is only relevant for TLS < 1.3.

This was a recent request from #5667.

RELEASE NOTES: none

@matthewstevenson88 matthewstevenson88 added the Type: Feature New features or improvements in behavior label May 24, 2024
@matthewstevenson88 matthewstevenson88 self-assigned this May 24, 2024
@matthewstevenson88 matthewstevenson88 added this to the 1.65 Release milestone May 24, 2024
@matthewstevenson88 matthewstevenson88 marked this pull request as ready for review May 24, 2024 22:53
Copy link
Contributor

@gtcooke94 gtcooke94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dfawley dfawley assigned dfawley and unassigned gtcooke94 May 28, 2024
@dfawley dfawley changed the title [tls] Plumb ciphersuites through advanced TLS options. advancedtls: add CipherSuites to Options May 29, 2024
@dfawley dfawley merged commit 11872f1 into grpc:master May 29, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature New features or improvements in behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants