Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

advancedtls: unexport parts of API not meant to be public #7118

Merged
merged 5 commits into from
Apr 17, 2024
Merged

advancedtls: unexport parts of API not meant to be public #7118

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b048720
unexport revocatio checking fns
gtcooke94 Apr 10, 2024
3a76a85
unexport ServerNameOverride in advancedtls
gtcooke94 Apr 10, 2024
166ecf4
unexport RevocationStatus
gtcooke94 Apr 10, 2024
533631b
remove revocation status String because it is unused
gtcooke94 Apr 10, 2024
4aac1bb
add more comment to serverNameOverride
gtcooke94 Apr 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
add more comment to serverNameOverride
  • Loading branch information
@gtcooke94
gtcooke94 committed Apr 11, 2024
commit 4aac1bb12a35e6473a6c061af23a83eb6f8db777
7 changes: 4 additions & 3 deletions security/advancedtls/advancedtls.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,9 +189,10 @@ type ClientOptions struct {
// By default, the maximum version supported by this package is used,
// which is currently TLS 1.3.
MaxVersion uint16
// serverNameOverride is for testing only. If set to a non-empty string,
// it will override the virtual host name of authority (e.g. :authority
// header field) in requests.
// serverNameOverride is for testing only. If set to a non-empty string, it
// will override the virtual host name of authority (e.g. :authority header
// field) in requests and the target hostname used during server cert
// verification.
serverNameOverride string
}

Expand Down
Loading