vet: split vet-proto from vet.sh #7099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #7099 +/- ##
==========================================
- Coverage 81.32% 81.19% -0.14%
==========================================
Files 345 345
Lines 33927 33927
==========================================
- Hits 27592 27547 -45
- Misses 5174 5213 +39
- Partials 1161 1167 +6 |
arvindbr8
changed the title
|
Discussed offline with @dfawley and decided to get rid of the env-variables fully, and just split to the logic to another bash file. |
dfawley
reviewed
Apr 5, 2024
dfawley
approved these changes
Apr 5, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move all the vet-proto logic to its own file
RELEASE NOTES: none