Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xds/internal/balancer/outlierdetection: Switch Outlier Detection to use new duration field #6286

Merged
merged 4 commits into from
May 18, 2023
Merged

xds/internal/balancer/outlierdetection: Switch Outlier Detection to use new duration field #6286

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
643d502
Switch Outlier Detection to use new duration field
zasweq May 15, 2023
2d49ade
Responded to Doug's comments
zasweq May 16, 2023
63c765e
Duration
zasweq May 16, 2023
7fdd9e1
Naming
zasweq May 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Responded to Doug's comments
  • Loading branch information
@zasweq
zasweq committed May 16, 2023
commit 2d49ade512331febdf6ee93dd7ffa07989561be9
1 change: 0 additions & 1 deletion xds/internal/balancer/outlierdetection/balancer_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,7 +358,6 @@ func (s) TestChildBasicOperations(t *testing.T) {
// it's first update.
od.UpdateClientConnState(balancer.ClientConnState{
BalancerConfig: &LBConfig{
Interval: math.MaxInt64, // what's the equivalent of this?
ChildPolicy: &iserviceconfig.BalancerConfig{
Name: t.Name() + "child1",
Config: bc,
Expand Down
16 changes: 8 additions & 8 deletions xds/internal/balancer/outlierdetection/e2e_test/outlierdetection_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,8 +159,8 @@ func (s) TestOutlierDetectionAlgorithmsE2E(t *testing.T) {
"loadBalancingConfig": [
{
"outlier_detection_experimental": {
"interval": ".05s",
"baseEjectionTime": ".1s",
"interval": "0.050s",
"baseEjectionTime": "0.100s",
"maxEjectionTime": "300s",
"maxEjectionPercent": 33,
"successRateEjection": {
Expand All @@ -182,8 +182,8 @@ func (s) TestOutlierDetectionAlgorithmsE2E(t *testing.T) {
"loadBalancingConfig": [
{
"outlier_detection_experimental": {
"interval": ".05s",
"baseEjectionTime": ".1s",
"interval": "0.050s",
"baseEjectionTime": "0.100s",
"maxEjectionTime": "300s",
"maxEjectionPercent": 33,
"failurePercentageEjection": {
Expand Down Expand Up @@ -277,8 +277,8 @@ func (s) TestNoopConfiguration(t *testing.T) {
"loadBalancingConfig": [
{
"outlier_detection_experimental": {
"interval": ".05s",
"baseEjectionTime": ".1s",
"interval": "0.050s",
"baseEjectionTime": "0.100s",
"maxEjectionTime": "300s",
"maxEjectionPercent": 33,
"childPolicy": [{"round_robin": {}}]
Expand Down Expand Up @@ -325,8 +325,8 @@ func (s) TestNoopConfiguration(t *testing.T) {
"loadBalancingConfig": [
{
"outlier_detection_experimental": {
"interval": ".05s",
"baseEjectionTime": ".1s",
"interval": "0.050s",
"baseEjectionTime": "0.100s",
"maxEjectionTime": "300s",
"maxEjectionPercent": 33,
"failurePercentageEjection": {
Expand Down