client: Add dial option to disable global dial options #6016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfawley
approved these changes
Feb 14, 2023
Comment on lines
71
to
72
| } else { | ||
| if !strings.Contains(err.Error(), "no transport security set") { |
There was a problem hiding this comment.
Nit: combine these lines. You can also combine both cases themselves by doing:
if _, err := Dial("fake", internal.Disable...); !strings.Contains(fmt.Sprint(err), "no transport security set") {There was a problem hiding this comment.
Oh right nice thanks. Switched.
|
|
||
| // newDisableGlobalDialOptions returns a DialOption that prevents the ClientConn | ||
| // from applying the global DialOptions (set via AddGlobalDialOptions). | ||
| func newDisableGlobalDialOptions() DialOption { |
There was a problem hiding this comment.
Nit/bikeshed: s/new//? Then you'd have to rename disableGlobalDialOptions to disableGlobalDialOptionsOption. Maybe this is fine then.
There was a problem hiding this comment.
Ok, will leave as such.
zasweq
commented
Feb 14, 2023
|
|
||
| // newDisableGlobalDialOptions returns a DialOption that prevents the ClientConn | ||
| // from applying the global DialOptions (set via AddGlobalDialOptions). | ||
| func newDisableGlobalDialOptions() DialOption { |
There was a problem hiding this comment.
Ok, will leave as such.
Comment on lines
71
to
72
| } else { | ||
| if !strings.Contains(err.Error(), "no transport security set") { |
There was a problem hiding this comment.
Oh right nice thanks. Switched.
zasweq
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a dial option to disable global dial options. This will be used in the observability module only, thus it is kept internal. The intended use case is to replace the observability modules instrumentation components registered globally (binary logger, in future: interceptor, and stats handler) to new components (just the interceptor and stats handler) for certain Client Conns (disableGlobalDialOptions + opencensus.DialOption(disableTrace = true). This is to avoid a loop where exporters using grpc.ClientConns create their own telemetry data due to the global registration of instrumentation components.
RELEASE NOTES: N/A