grpc: Add join Dial Option #5861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfawley
approved these changes
Dec 14, 2022
Comment on lines
29
to
30
| const maxRecvSize = 998765 | ||
| const initialWindowSize = 100 |
There was a problem hiding this comment.
Please make these local inside their tests.
There was a problem hiding this comment.
This is used 4/2 times, respectively?
There was a problem hiding this comment.
Actually this is in grpc I see I'll move to tests.
internal/internal.go
Outdated
| @@ -77,6 +77,9 @@ var ( | |||
| // ClearGlobalDialOptions clears the array of extra DialOption. This | |||
| // method is useful in testing and benchmarking. | |||
| ClearGlobalDialOptions func() | |||
| // JoinDialOptions combines the dial options passed as arguments into a | |||
| // single dial option. | |||
| JoinDialOptions interface{} | |||
There was a problem hiding this comment.
Please comment: // func(...grpc.DialOption) grpc.DialOption
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a join Dial Option. It also contains tests for this join Dial Option and the already present join Server Option.
RELEASE NOTES: N/A