Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint: fix some unused parameter issues #4956

Merged
merged 1 commit into from
Nov 9, 2021
Merged

Conversation

rleungx
Copy link
Contributor

@rleungx rleungx commented Nov 5, 2021

Remove some unused parameters.

RELEASE NOTES: None

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 5, 2021

CLA Signed

The committers are authorized under a signed CLA.

@zasweq
Copy link
Contributor

zasweq commented Nov 6, 2021

This doesn't feel right. Assigning to file owner Ashitha to take a look. This looks like it creates functional change as well. Also, our vet didn't seem to complain around these files.

@ashithasantosh
Copy link
Contributor

This doesn't feel right. Assigning to file owner Ashitha to take a look. This looks like it creates functional change as well. Also, our vet didn't seem to complain around these files.

I only own rbac_translator.go, and the changes there LGTM. Thanks for doing this.
You may want to add other file owners to reviewer list.

@dfawley
Copy link
Member

dfawley commented Nov 8, 2021

@zasweq you said you may have noticed a behavior change somewhere? If so, please comment the line. I quickly reviewed and everything seemed correct, but I didn't look super closely, either.

@zasweq
Copy link
Contributor

zasweq commented Nov 9, 2021

LGTM, outside of the vet failure. Thanks for this. I had an unused testing.T parameter in my cluster handler test that I based off other tests in the codebase (both of which got removed), which I thought was required for testing haha.

@zasweq zasweq assigned rleungx and unassigned zasweq Nov 9, 2021
@dfawley
Copy link
Member

dfawley commented Nov 9, 2021

vet-proto is not required to pass to submit; this appears to be unrelated. I'll merge this now.

@dfawley dfawley merged commit 14ebd91 into grpc:master Nov 9, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants