-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lint: fix some unused parameter issues #4956
Conversation
|
This doesn't feel right. Assigning to file owner Ashitha to take a look. This looks like it creates functional change as well. Also, our vet didn't seem to complain around these files. |
I only own rbac_translator.go, and the changes there LGTM. Thanks for doing this. |
Signed-off-by: Ryan Leung <[email protected]>
@zasweq you said you may have noticed a behavior change somewhere? If so, please comment the line. I quickly reviewed and everything seemed correct, but I didn't look super closely, either. |
LGTM, outside of the vet failure. Thanks for this. I had an unused testing.T parameter in my cluster handler test that I based off other tests in the codebase (both of which got removed), which I thought was required for testing haha. |
|
Remove some unused parameters.
RELEASE NOTES: None