Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

client: include details about GOAWAYs in status messages #4316

Merged
merged 11 commits into from
Apr 24, 2021
Merged

client: include details about GOAWAYs in status messages #4316

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
ba8e17b
Propagate errors causing connection close to RPC statuses
apolcyn Mar 31, 2021
0640203
fix transport tests
apolcyn Apr 1, 2021
38da1fd
Make test deterministic
apolcyn Apr 1, 2021
b1f5e59
Include details about possible goaways when terminating RPCs due to
apolcyn Apr 1, 2021
7dee6ae
skip handler-tls config for max age goaway error test
apolcyn Apr 2, 2021
052d632
Merge remote-tracking branch 'upstream/master' into propagage_goaway_…
apolcyn Apr 14, 2021
eef6755
make test use stubserver
apolcyn Apr 14, 2021
afed69f
address review comment
apolcyn Apr 14, 2021
9277ca5
address comment from https://github.com/grpc/grpc-go/pull/4311#discus…
apolcyn Apr 14, 2021
5270ce5
fix typo
apolcyn Apr 14, 2021
c23ff7f
Merge remote-tracking branch 'upstream/master' into propagage_goaway_…
apolcyn Apr 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
address comment from #4311 (comment)
  • Loading branch information
@apolcyn
apolcyn committed Apr 14, 2021
commit 9277ca559d0e89475d8d0faf5b9ad7d265d8e943
3 changes: 1 addition & 2 deletions internal/transport/http2_client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1155,8 +1155,7 @@ func (t *http2Client) handleGoAway(f *http2.GoAwayFrame) {
}
}
id := f.LastStreamID
// TODO(apolcyn): address this review comment
if id > 0 && id%2 != 1 {
if id > 0 && id%2 == 0 {
t.mu.Unlock()
t.Close(connectionErrorf(true, nil, "received goaway with non-zero even-numbered numbered stream id: %v", id))
return
Expand Down