Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal: remove withResolverBuilder and use WithResolvers instead #3321

Merged
merged 6 commits into from
Jan 15, 2020
Merged

internal: remove withResolverBuilder and use WithResolvers instead #3321

merged 6 commits into from
Jan 15, 2020

Conversation

dfawley
Copy link
Member

@dfawley dfawley commented Jan 14, 2020

No description provided.

@dfawley dfawley requested a review from menghanl January 14, 2020 20:55
@dfawley dfawley changed the title cleanup: remove internal.WithResolverBuilder and use WithResolvers instead internal: remove WithResolverBuilder and use WithResolvers instead Jan 14, 2020
@menghanl menghanl changed the title internal: remove WithResolverBuilder and use WithResolvers instead internal: remove withResolverBuilder and use WithResolvers instead Jan 14, 2020
menghanl
menghanl reviewed Jan 14, 2020
View reviewed changes
clientconn.go Outdated Show resolved Hide resolved
@dfawley dfawley merged commit cd74fa2 into grpc:master Jan 15, 2020
@dfawley dfawley deleted the noResolverBuilder branch January 15, 2020 16:54
@menghanl menghanl mentioned this pull request Feb 14, 2020
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@menghanl menghanl menghanl approved these changes

Assignees

@menghanl menghanl

Labels
Type: Internal Cleanup Refactors, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dfawley @menghanl