Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: typos #2591

Merged
merged 1 commit into from
Jan 23, 2019
Merged

fix: typos #2591

merged 1 commit into from
Jan 23, 2019

Conversation

wrfly
Copy link
Contributor

@wrfly wrfly commented Jan 23, 2019

No description provided.

dfawley
dfawley approved these changes Jan 23, 2019
View reviewed changes
Copy link
Member

@dfawley dfawley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

What did you use to discover these? (I'd like to put something into our vet.sh to prevent new typos from appearing.)

@dfawley dfawley merged commit e9c1ac3 into grpc:master Jan 23, 2019
@wrfly
Copy link
Contributor Author

wrfly commented Jan 24, 2019

There's a VSCode extension https://github.com/Jason-Rev/vscode-spell-checker

I'm reading the source code recently and find these typos thanks to this plugin. 😃

@lock lock bot locked as resolved and limited conversation to collaborators Jul 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dfawley dfawley dfawley approved these changes

Assignees
No one assigned
Labels
Type: Internal Cleanup Refactors, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wrfly @dfawley