cleanup: replace "x/net/context" import with "context" #2439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
menghanl
reviewed
Nov 10, 2018
| set -o pipefail | ||
| git reset --hard HEAD | ||
| # END TODO | ||
| go tool vet -all . |
There was a problem hiding this comment.
Do we still modify user's code? Is git status --porcelain at the beginning of this file still necessary?
There was a problem hiding this comment.
We still do the go generate check based on that, so we do still need it.
| @@ -4,8 +4,9 @@ | |||
| package mock_helloworld | |||
|
|
|||
| import ( | |||
| context "context" | |||
There was a problem hiding this comment.
Was this changed manually? (Same question for route_guide mock)
There was a problem hiding this comment.
Yes, I'll revert it. We should really have these hooked up with go generate too.
menghanl
approved these changes
Nov 12, 2018
This was referenced Nov 22, 2018
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #711