Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

transport: avoid extra work for keepalive when it's disabled. #2148

Merged
merged 1 commit into from
Jun 14, 2018
Merged

transport: avoid extra work for keepalive when it's disabled. #2148

merged 1 commit into from
Jun 14, 2018

Conversation

MakMukhi
Copy link
Contributor

fixes #1922

@MakMukhi MakMukhi requested a review from dfawley June 13, 2018 22:43
@MakMukhi MakMukhi merged commit e074afe into grpc:master Jun 14, 2018
@menghanl menghanl changed the title Don't do extra work for keepalive when it's disabled. transport: avoid extra work for keepalive when it's disabled. Jun 19, 2018
@menghanl menghanl added this to the 1.13 Release milestone Jun 19, 2018
@MakMukhi MakMukhi deleted the keepalive_optimize branch June 20, 2018 18:04
@lock lock bot locked as resolved and limited conversation to collaborators Dec 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dfawley dfawley dfawley approved these changes

Assignees

@dfawley dfawley

Labels
Type: Bug
Projects
None yet
Milestone
1.13 Release
Development

Successfully merging this pull request may close these issues.

When keepalive is turned off, don't update corresponding counters
3 participants
@MakMukhi @dfawley @menghanl