Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

documentation: mention DialContext is non-blocking by default #1970

Merged
merged 2 commits into from
Apr 12, 2018
Merged

documentation: mention DialContext is non-blocking by default #1970

merged 2 commits into from
Apr 12, 2018

Conversation

menghanl
Copy link
Contributor

@menghanl menghanl commented Apr 5, 2018

fixes #1953

@nhooyr
Copy link

nhooyr commented Apr 8, 2018

Should mention that in the non blocking case, the ctx does not act against the dial but how long the non blocking dial takes to setup. As in, thats what could potentially make it useful in the non blocking case.

@lyuxuan lyuxuan merged commit 35aeaeb into grpc:master Apr 12, 2018
@menghanl menghanl deleted the dial_ctx_blocking branch April 12, 2018 22:52
@lock lock bot locked as resolved and limited conversation to collaborators Oct 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lyuxuan lyuxuan lyuxuan approved these changes

Assignees

@lyuxuan lyuxuan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Why is DialContext not blocking by default?
3 participants
@menghanl @nhooyr @lyuxuan