stream: split per-attempt data from clientStream #1900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lyuxuan
suggested changes
Mar 9, 2018
| } | ||
| if cs.trInfo.tr != nil { | ||
| if a.trInfo.tr != nil { |
There was a problem hiding this comment.
Missing the outter conditional?
if EnableTracing {
if a.trInfo.tr != nil {
....
}
There was a problem hiding this comment.
We are holding a.mu here, so looking at only a.trInfo.tr is good. The only reason to check EnableTracing in the other cases is to avoid taking the lock if tracing is disabled globally.
lyuxuan
approved these changes
Mar 12, 2018
dfawley
changed the title
lyuxuan
pushed a commit
to lyuxuan/grpc-go
that referenced
this pull request
Apr 4, 2018
This is pre-work to implementing retry support. Each retry attempt will have its own csAttempt. The fields left in clientStream are the same across all attempts.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is pre-work to implementing retry support. Each retry attempt will have its own
csAttempt. The fields left in clientStream are the same across all attempts.