Fix race in TestCloseConnectionWhenServerPrefaceNotReceived #1897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfawley
reviewed
Mar 5, 2018
clientconn.go
Outdated
| // We use an accessor so that minConnectTimeout can be | ||
| // atomically read and updated while testing. | ||
| getMinConnectTimeout = func() time.Duration { | ||
| return minConnectTimeout |
There was a problem hiding this comment.
Could you make minConnectTimeout a const, and move the var to be in the test only?
dfawley
approved these changes
Mar 7, 2018
dfawley
changed the title
|
Seeing failure again: https://travis-ci.org/grpc/grpc-go/jobs/396660661 |
|
@lyuxuan unfortunately the info in travis is lost when you re-run the job -- better to copy/paste the failure text. Was this the same race detector error? |
|
Ops. (I remember it used to work???) It's not race detector error. I remember it's error caused by empty address list. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Atomically modify minConnecTimout in testing environment to avoid write-after-read detection.