Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document that all errors from RPCs are status errors #1782

Merged
merged 2 commits into from
Jan 5, 2018
Merged

Document that all errors from RPCs are status errors #1782

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2e76ccd
Document that all errors from RPCs are status errors
menghanl Jan 5, 2018
39df0b3
2
menghanl Jan 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
2
  • Loading branch information
@menghanl
menghanl committed Jan 5, 2018
commit 39df0b324aeb322f4e73ce4f27741dec2aa069cb
2 changes: 1 addition & 1 deletion call.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ func sendRequest(ctx context.Context, dopts dialOptions, compressor Compressor,
// Invoke sends the RPC request on the wire and returns after response is
// received. This is typically called by generated code.
//
// All errors returned by Invoke are status errors.
// All errors returned by Invoke are compatible with the status package.
func (cc *ClientConn) Invoke(ctx context.Context, method string, args, reply interface{}, opts ...CallOption) error {
if cc.dopts.unaryInt != nil {
return cc.dopts.unaryInt(ctx, method, args, reply, cc, invoke, opts...)
Expand Down
2 changes: 1 addition & 1 deletion stream.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ type StreamDesc struct {

// Stream defines the common interface a client or server stream has to satisfy.
//
// All errors returned from Stream are status errors.
// All errors returned from Stream are compatible with the status package.
type Stream interface {
// Context returns the context for this stream.
Context() context.Context
Expand Down