Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky test TestCloseConnectionWhenServerPrefaceNotReceived #1732

Merged
merged 1 commit into from
Dec 14, 2017

Conversation

MakMukhi
Copy link
Contributor

@MakMukhi MakMukhi commented Dec 13, 2017

Make sure all goroutines have ended before restoring global vars.

fixes #1716

@dfawley
Copy link
Member

dfawley commented Dec 14, 2017

🤢 😀

@MakMukhi MakMukhi merged commit b8cf13e into grpc:master Dec 14, 2017
@dfawley dfawley changed the title Make sure all goroutines have ended before restoring global vars. Fix flaky test TestCloseConnectionWhenServerPrefaceNotReceived Dec 14, 2017
@dfawley dfawley added this to the 1.9 Milestone milestone Jan 2, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky test: TestCloseConnectionWhenServerPrefaceNotReceived
2 participants