Add and use connectivity package for states #1430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dzbarsky FYI, we will be changing the connectivity API slightly in this PR (to support upcoming work revamping the resolver and balancer logic), in case you are using it already. |
dfawley
reviewed
Aug 8, 2017
| @@ -587,9 +554,9 @@ type ClientConn struct { | |||
| mkp keepalive.ClientParameters | |||
| } | |||
|
|
|||
| // WaitForStateChange waits until the ConnectivityState of ClientConn changes from sourceState or | |||
| // WaitForStateChange waits until the connectivity.State of ClientConn changes from sourceState or | |||
| // ctx expires. A true value is returned in former case and false in latter. | |||
There was a problem hiding this comment.
Yeesh, we didn't write the "experimental" disclaimer here. Can you add it?
| @@ -602,8 +569,8 @@ func (cc *ClientConn) WaitForStateChange(ctx context.Context, sourceState Connec | |||
| } | |||
| } | |||
|
|
|||
| // GetState returns the ConnectivityState of ClientConn. | |||
| func (cc *ClientConn) GetState() ConnectivityState { | |||
| // GetState returns the connectivity.State of ClientConn. | |||
|
@dfawley thanks for the warning, we're already using this since we were blocked on it for a while. It looks like this just moved it to a separate package so that shouldn't be a problem for us. Please let us know if there are any actual breaking changes, thanks! |
dfawley
approved these changes
Aug 8, 2017
menghanl
added a commit
to menghanl/grpc-go
that referenced
this pull request
Aug 10, 2017
Add and use connectivity package for states (grpc#1430) * Add and use connectivity package * Mark cc state APIs as experimental Add balancer, resolver and connectivity package. add balancer_v1_wrapper.go and remove grpclb.go all test passed, how? end2end passed, nil pointer failure, ac.wait return nil transport fix ac.wait return nil transport, races not fixed (accessing cc.balancer) end2end passed, TODO grpclb all test passed add grpclb back move building balancer out from a goroutine to avoid race Otherwise, Dial() and Close() may race. Mark new APIs experimental split resetAddrConn into newAddrConn and connect add acBalancerWrapper rename file to balancer_conn_wrappers.go remove grpclog.Print make TODO(bar) remove Print comments fixes add missing license fix build failure after merge fix race in grpclb
menghanl
added a commit
to menghanl/grpc-go
that referenced
this pull request
Aug 10, 2017
Add and use connectivity package for states (grpc#1430) * Add and use connectivity package * Mark cc state APIs as experimental Add balancer, resolver and connectivity package. add balancer_v1_wrapper.go and remove grpclb.go all test passed, how? end2end passed, nil pointer failure, ac.wait return nil transport fix ac.wait return nil transport, races not fixed (accessing cc.balancer) end2end passed, TODO grpclb all test passed add grpclb back move building balancer out from a goroutine to avoid race Otherwise, Dial() and Close() may race. Mark new APIs experimental split resetAddrConn into newAddrConn and connect add acBalancerWrapper rename file to balancer_conn_wrappers.go remove grpclog.Print make TODO(bar) remove Print comments fixes add missing license fix build failure after merge fix race in grpclb
menghanl
added a commit
that referenced
this pull request
Aug 14, 2017
* Add and use connectivity package * Mark cc state APIs as experimental
menghanl
added a commit
to menghanl/grpc-go
that referenced
this pull request
Aug 16, 2017
Add and use connectivity package for states (grpc#1430) * Add and use connectivity package * Mark cc state APIs as experimental Add balancer, resolver and connectivity package. add balancer_v1_wrapper.go and remove grpclb.go all test passed, how? end2end passed, nil pointer failure, ac.wait return nil transport fix ac.wait return nil transport, races not fixed (accessing cc.balancer) end2end passed, TODO grpclb all test passed add grpclb back move building balancer out from a goroutine to avoid race Otherwise, Dial() and Close() may race. Mark new APIs experimental split resetAddrConn into newAddrConn and connect add acBalancerWrapper rename file to balancer_conn_wrappers.go remove grpclog.Print make TODO(bar) remove Print comments fixes add missing license fix build failure after merge fix race in grpclb
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.