Calling handleRPC with context derived from the original #1227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
menghanl
changed the title
dfawley
reviewed
May 10, 2017
stats/handlers.go
Outdated
| } | ||
|
|
||
| // RPCTagInfo defines the relevant information needed by RPC context tagger. | ||
| // FailFast is only valid on client side, it's always false on server side. |
There was a problem hiding this comment.
I think it would be more appropriate to document this on the field than on the struct.
How far do we think we will be extending this struct? Would it make sense to have sub-structures for client- and server- only fields?
menghanl
force-pushed
the
add_failfast_to_taginfo
branch
from
36411ba
to
54acba7
Compare
dfawley
approved these changes
May 11, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that the context for stats handlers will have the other information as normal contexts.
Also added FailFast to TagInfo in case stats handlers care about FailFast but don't want to handle begin stats.