Do not clear headers when switching between tabs

[klippx]

Issue

When switching between tabs, the default header state is lost and replaced with empty string.

Demo of the bug:

Screen.Recording.2024-03-06.at.10.47.10.mov

Codepen to verify/reproduce the issue:

In this example we are using defaultHeaders, and when using multiple tabs, upon reload the headers are cleared when switching tabs.

https://codesandbox.io/p/sandbox/determined-brook-rp683x?file=/package.json:11,23

Note: If you edit the headers before switching tabs, they are not cleared. I am guessing that they are then instead stored in the internal state.

[changeset-bot]

🦋 Changeset detected

Latest commit: 72a8e6f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@graphiql/react	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[acao]

good find, thank you!

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.60%. Comparing base (c02caf2) to head (72a8e6f).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #3552   +/-   ##
=======================================
  Coverage   67.60%   67.60%           
=======================================
  Files         121      121           
  Lines        6968     6968           
  Branches     2247     2247           
=======================================
  Hits         4711     4711           
  Misses       2240     2240           
  Partials       17       17           

Files	Coverage Δ
packages/graphiql-react/src/editor/context.tsx	76.22% <100.00%> (ø)
packages/graphiql-react/src/editor/tabs.ts	60.97% <100.00%> (ø)

[klippx]

@acao Would it be OK to merge?

[klippx]

I pushed another commit since it would just use whatever you have in the editor and not overwrite it, using default headers is a better choice when switching tabs.

Before:

• Default headers only apply when creating a NEW tab
  After:
• When switching tab, apply headers || defaultHeaders

[klippx]

I have two PRs open that initially seem well received, how come we don't move forward and merge if they are perceived as good changes? @acao

[acao]

@klippx sorry I have been super busy lately and there was something else I needed to check, I cannot remember what held me up last time but I think this should be good to go, perhaps @thomasheyenbrock if you have a chance to look and think this is good to go feel free to merge

[klippx]

@thomasheyenbrock can you take a look at this as well? 🙏

[klippx]

@dimaMachina 👀 want to take a look?